Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New feature: Include results in LaTeX report #267

Merged
merged 11 commits into from
May 17, 2021
Merged

Conversation

fwitte
Copy link
Member

@fwitte fwitte commented May 16, 2021

Report now optionally includes results.

ToDo:

  • Chars are not documented if part of a char only parameter group (e.g. kA_char of HeatExchangers)
  • Update online documentation
  • API documentation in document_models module
  • Update What's New

Would be nice to have:

  • Custom number formatting (somewhat)
  • Custom connection parameter reporting selection
  • Custom component parameter reporting selection
  • Exergy Analysis report feature

@pep8speaks
Copy link

pep8speaks commented May 16, 2021

Hello @fwitte! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

Line 36:80: E501 line too long (81 > 79 characters)

Line 73:80: E501 line too long (80 > 79 characters)

Comment last updated at 2021-05-17 13:40:21 UTC

@lgtm-com
Copy link

lgtm-com bot commented May 17, 2021

This pull request introduces 3 alerts when merging 081831b into 65383e2 - view on LGTM.com

new alerts:

  • 2 for Unused import
  • 1 for Wrong name for an argument in a call

@lgtm-com
Copy link

lgtm-com bot commented May 17, 2021

This pull request introduces 3 alerts when merging 94ae16c into 65383e2 - view on LGTM.com

new alerts:

  • 2 for Unused import
  • 1 for Wrong name for an argument in a call

@fwitte fwitte merged commit 8ca8e3a into dev May 17, 2021
@lgtm-com
Copy link

lgtm-com bot commented May 17, 2021

This pull request introduces 1 alert when merging a4a0fa9 into 65383e2 - view on LGTM.com

new alerts:

  • 1 for Wrong name for an argument in a call

@fwitte fwitte deleted the feature/result_report branch July 14, 2021 10:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants