Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/thermosteam #327

Closed
wants to merge 6 commits into from
Closed

Conversation

nkawerau
Copy link
Contributor

@nkawerau nkawerau commented Apr 8, 2022

This feature provides the option to use Thermosteam (https://thermosteam.readthedocs.io/en/latest/) as fluid properties back end, located in tespy/tools/fluid_properties.py. Use the keyword "TS" for Thermosteam instead of the standard usage of "HEOS" (Helmholtz equation of state).

Example: fluid_network = Network( fluids = ["TS::H2O", "TS::KOH"] )

For now, the feature is designed to use aqueous potassium hydroxide [H20(l) + KOH(aq)] as liquid fluid components and hydrogen + oxygen [H2(g) + O2(g)] as gaseous fluid components, a more generalized approach is targeted.

@pep8speaks
Copy link

pep8speaks commented Apr 8, 2022

Hello @nkawerau! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

Line 30:1: E402 module level import not at top of file
Line 31:1: E402 module level import not at top of file
Line 32:1: E402 module level import not at top of file
Line 92:40: E712 comparison to True should be 'if cond is True:' or 'if cond:'
Line 106:80: E501 line too long (83 > 79 characters)
Line 115:80: E501 line too long (112 > 79 characters)
Line 131:80: E501 line too long (82 > 79 characters)
Line 169:80: E501 line too long (80 > 79 characters)
Line 170:80: E501 line too long (117 > 79 characters)
Line 171:80: E501 line too long (116 > 79 characters)
Line 172:80: E501 line too long (116 > 79 characters)
Line 363:35: E225 missing whitespace around operator
Line 363:35: E712 comparison to True should be 'if cond is True:' or 'if cond:'
Line 366:80: E501 line too long (102 > 79 characters)
Line 368:80: E501 line too long (102 > 79 characters)
Line 370:80: E501 line too long (82 > 79 characters)
Line 656:36: E712 comparison to True should be 'if cond is True:' or 'if cond:'
Line 659:80: E501 line too long (102 > 79 characters)
Line 661:80: E501 line too long (102 > 79 characters)
Line 1153:36: E712 comparison to True should be 'if cond is True:' or 'if cond:'
Line 1156:80: E501 line too long (102 > 79 characters)
Line 1158:80: E501 line too long (102 > 79 characters)
Line 1160:80: E501 line too long (82 > 79 characters)
Line 1163:80: E501 line too long (101 > 79 characters)
Line 1330:36: E712 comparison to True should be 'if cond is True:' or 'if cond:'
Line 1333:80: E501 line too long (102 > 79 characters)
Line 1335:80: E501 line too long (102 > 79 characters)
Line 1340:80: E501 line too long (101 > 79 characters)
Line 1448:35: E225 missing whitespace around operator
Line 1448:35: E712 comparison to True should be 'if cond is True:' or 'if cond:'
Line 1451:80: E501 line too long (102 > 79 characters)
Line 1453:80: E501 line too long (102 > 79 characters)
Line 1455:80: E501 line too long (82 > 79 characters)
Line 1544:35: E225 missing whitespace around operator
Line 1544:35: E712 comparison to True should be 'if cond is True:' or 'if cond:'
Line 1547:80: E501 line too long (102 > 79 characters)
Line 1549:80: E501 line too long (102 > 79 characters)
Line 1635:36: E712 comparison to True should be 'if cond is True:' or 'if cond:'
Line 1638:80: E501 line too long (102 > 79 characters)
Line 1640:80: E501 line too long (102 > 79 characters)
Line 1642:80: E501 line too long (82 > 79 characters)
Line 1645:80: E501 line too long (109 > 79 characters)
Line 1729:36: E712 comparison to True should be 'if cond is True:' or 'if cond:'
Line 1732:80: E501 line too long (102 > 79 characters)
Line 1734:80: E501 line too long (102 > 79 characters)
Line 1739:80: E501 line too long (109 > 79 characters)
Line 1996:1: E302 expected 2 blank lines, found 0
Line 1996:35: E261 at least two spaces before inline comment
Line 1998:80: E501 line too long (108 > 79 characters)
Line 1999:80: E501 line too long (130 > 79 characters)
Line 1999:123: E261 at least two spaces before inline comment
Line 2002:80: E501 line too long (80 > 79 characters)
Line 2006:80: E501 line too long (80 > 79 characters)
Line 2007:80: E501 line too long (92 > 79 characters)
Line 2011:1: E302 expected 2 blank lines, found 1
Line 2016:80: E501 line too long (110 > 79 characters)
Line 2026:80: E501 line too long (102 > 79 characters)
Line 2035:80: E501 line too long (118 > 79 characters)
Line 2040:1: E302 expected 2 blank lines, found 1
Line 2040:24: E261 at least two spaces before inline comment
Line 2046:80: E501 line too long (90 > 79 characters)
Line 2050:1: E302 expected 2 blank lines, found 1
Line 2050:80: E501 line too long (80 > 79 characters)
Line 2051:80: E501 line too long (93 > 79 characters)
Line 2053:80: E501 line too long (91 > 79 characters)
Line 2086:1: E302 expected 2 blank lines, found 1
Line 2087:57: E261 at least two spaces before inline comment
Line 2106:23: E261 at least two spaces before inline comment
Line 2108:1: E302 expected 2 blank lines, found 1

Comment last updated at 2022-05-10 07:26:57 UTC

@lgtm-com
Copy link

lgtm-com bot commented Apr 8, 2022

This pull request introduces 4 alerts when merging 58d7112 into 26865e3 - view on LGTM.com

new alerts:

  • 3 for Unused local variable
  • 1 for Unused import

@lgtm-com
Copy link

lgtm-com bot commented May 7, 2022

This pull request introduces 3 alerts when merging 7d9b530 into c2a8793 - view on LGTM.com

new alerts:

  • 2 for Unused local variable
  • 1 for Unused import

@lgtm-com
Copy link

lgtm-com bot commented May 8, 2022

This pull request introduces 3 alerts when merging 13be157 into c2a8793 - view on LGTM.com

new alerts:

  • 2 for Unused local variable
  • 1 for Unused import

(auqueous KOH, at 243.15 K and 30 mass percent)
@lgtm-com
Copy link

lgtm-com bot commented May 10, 2022

This pull request introduces 3 alerts when merging f30a84c into 705b644 - view on LGTM.com

new alerts:

  • 2 for Unused local variable
  • 1 for Unused import

@fwitte fwitte mentioned this pull request Jun 1, 2022
15 tasks
@fwitte
Copy link
Member

fwitte commented May 11, 2023

This will fall into works of #384, closing here for now.

@fwitte fwitte closed this May 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants