fix electrolyzer documentation #335
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
April 29, 2022 10:50
… hydrogen's higher heating value (not lower heating value)
|
Hello @BenPortner! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found: There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻 Comment last updated at 2022-04-29 15:32:12 UTC |
fwitte
reviewed
Apr 29, 2022
| >>> import shutil | ||
| >>> import numpy as np |
There was a problem hiding this comment.
Thank you for noticing this, I wonder how the tests passed with the missing import... In this example it is only used to unset the volumetric flow of hydrogen to the compressor (L181/L182), I think I will remove it and use None instead. Originally, np.nan was used to unset values, None was introduced later. It seemed more convenient to me, since you do not necessarily need to import numpy.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.