sessionclean script stop working after upgrading 5.5.15+dfsg-1 --> 5.5.15+dfsg-2

[BahnhofMS]

This was due to the server defaulting to dash, when scripts begin with

!/bin/sh. With dash, output of echo differs in that flags suddenly aren't flags, as such:

$ echo -e
-e

Changing line 8 in /usr/lib/php5/sessionclean to instead use the echo binary:
/bin/echo -e "$SAPIS" |
seems to fix it.

[oerdnj]

Or just leave the -e;

I have already noticed this and fix is on it's way...

[BahnhofMS]

If -e is left out it will break on bash instead, causing read to only process the first entry in "$SAPIS"

[oerdnj]

The default shell in Debian and Ubuntu is dash. Is there a way how to reproduce it in real life deployment?

[BahnhofMS]

Fair point, but since the default is still a configuration option that can be changed, we should probably aim to keep "#!/bin/sh"-scripts portable.

We should use:
printf "%b\n" "$SAPIS" | \
...according to https://wiki.ubuntu.com/DashAsBinSh#echo
and http://www.unix.com/man-page/POSIX/1posix/echo/

[oerdnj]

Thanks for the tip, I have modified the script and it will included in next upload to the PPAs (and Debian)...

SAPIS="apache2:apache2\napache2filter:apache2\ncgi:php5\nfpm:php5-fpm\n"
[...]
printf "$SAPIS" | \

[BahnhofMS]

(Np, I should be thanging you for the work maintaining this. ^_^ Donation is on my todo, btw).
Personally I wouldn't skip "%b\n" and risk silently ignore the last tuple because of a missing final \n. But either way is ok.

[oerdnj]

Re: "%b\n"

I plan to rewrite that little bit more... see my discussion with Steve here: https://bugs.launchpad.net/ubuntu/+source/php5/+bug/1356113

P.S.: I now have a bitcoin address too :)