Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: enabled syntax highlighting #519

Open
wants to merge 7 commits into
base: development
Choose a base branch
from

Conversation

0xflotus
Copy link
Contributor

No description provided.

@m90
Copy link
Member

m90 commented Dec 19, 2020

Right now the setup for our docs site does not render syntax highlighting in any way, so if we wanted to add this, we'd probably have to make sure syntax highlighting gets displayed in the rendered docs as well.

As an aside: as all of the snippets are shell commands or configuration file (and no longer portions of code) I also wonder if syntax highlighting makes a real difference here.

@0xflotus
Copy link
Contributor Author

Ok, if it breaks the renderings of the docs site, it was a bad idea to add this.

Feel free to close this PR.

@m90
Copy link
Member

m90 commented Dec 19, 2020

Ok, if it breaks the renderings of the docs site, it was a bad idea to add this.

It doesn't really break anything, but until someone figures out how to enable syntax highlighting in the docs site, these changes would have no effect.

In case you are interested in venturing there and finding out how that works, we'd much appreciate it. In case not, I'd just leave this open until we find the time to do so ourselves.

Thank you in any case.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants