Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Language dropdown #24

Closed
nxtn opened this issue Apr 18, 2019 · 11 comments · Fixed by #37
Closed

Language dropdown #24

nxtn opened this issue Apr 18, 2019 · 11 comments · Fixed by #37

Comments

@nxtn
Copy link
Contributor

nxtn commented Apr 18, 2019

Could you add a language dropdown menu so that C# and VB snippets won't show up at the same time?

image

@Linda-Editor
Copy link

@NextTurn I'm not sure how to do that. Have you seen it somewhere else on docs.microsoft.com? If so, please send a link to the page. Thanks.

@nxtn
Copy link
Contributor Author

nxtn commented Apr 19, 2019

@Linda-Editor
Copy link

@NextTurn If you look in the API section, this functionality does exist there; for example: https://docs.microsoft.com/en-us/dotnet/api/documentformat.openxml.bibliography.abbreviatedcasenumber.localname?view=openxml-2.8.1

@nxtn
Copy link
Contributor Author

nxtn commented Apr 19, 2019

Yes, but could you make it apply to articles as well?

@Linda-Editor
Copy link

@NextTurn I'll look into it. Thanks for the suggestion.

@dmahugh - Doug, could you get this request to the right PM who can address it? Thanks...

@nxtn
Copy link
Contributor Author

nxtn commented Aug 18, 2019

The language selector dropdown menu is set in docfx.json.

See the following file for example

https://github.com/dotnet/dotnet-api-docs/blob/65c1594178155f1f1ddf00319ab3bbc9fe5bc01a/docfx.json#L133

@Linda-Editor
Copy link

@lindalu-MSFT can you follow up on this? It's about adding the language selector drop-down to conceptual topics in open-xml-docs. See the thread for more info. Thanks.

@lindalu-MSFT
Copy link
Collaborator

lindalu-MSFT commented Aug 19, 2019

@davidchesnut Hi David, can I get your help with this? I updated the JSON, added:

"langs": {
   "api/**.yml": ["csharp", "vb", "fsharp", "cpp"]
  }
},

and ran it through the JSON validator tool which came back as VALID.

We need to add the drop-down language selector. Any idea what I'm doing wrong? I have a branch called lindalu-MSFT-add-langs where I made the change.

@nxtn
Copy link
Contributor Author

nxtn commented Aug 24, 2019

@lindalu-MSFT Hi, please have a try with the following:

"langs": {
  "**/*.yml": ["csharp", "vb"]
}

@lindalu-MSFT
Copy link
Collaborator

@NextTurn Did that do the trick? Sorry I lost track of this issue for a few days. I was out sick! :(

@nxtn
Copy link
Contributor Author

nxtn commented Sep 10, 2019

@lindalu-MSFT I guess that is correct. Can you verify it? Thanks!

@nxtn nxtn mentioned this issue Nov 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants