[BUGFIX] Validate promise resolves even when validations are still validating #294
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* master: Added tests to show nested models don't properly validated (#293)
offirgolan
added a commit
that referenced
this pull request
Aug 11, 2016
* master: (26 commits) Provide `baseDir` to allow for proper caching. (#305) chore(package): update ember-cli-babel to version 5.1.8 (#315) chore(package): update ember-cli-htmlbars-inline-precompile to version 0.3.5 (#316) chore(package): update ember-ajax to version 2.5.1 (#313) chore(package): update ember-cli-htmlbars to version 1.1.0 (#314) [FEATURE] Place mixin under a named scope for Ember Inspector (#311) chore(package): update ember-cli-sri to version 2.1.1 (#307) chore(package): update ember-ajax to version 2.5.0 (#310) chore(package): update ember-cli-htmlbars-inline-precompile to version 0.3.4 (#309) chore(package): update ember-cli-app-version to version 2.0.0 (#303) Fix some docs chore(package): update broccoli-asset-rev to version 2.4.6 (#302) chore(package): update walk-sync to version 0.3.1 (#297) chore(package): update loader.js to version 4.0.11 (#298) chore(package): update ember-cli-app-version to version 1.0.1 (#299) chore(package): update ember-code-snippet to version 1.4.0 (#301) chore(package): update ember-cli-htmlbars to version 1.0.11 (#296) chore(package): update ember-cli-jshint to version 1.0.5 (#295) Released v3.0.0-beta.5 [BUGFIX] Validate promise resolves even when validations are still validating (#294) ... # Conflicts: # index.js # package.json
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #283.
Changes proposed:
Tasks: