Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using native Ember trackpad scroll emulator #40

Merged
merged 3 commits into from
Jun 9, 2016

Conversation

taras
Copy link
Collaborator

@taras taras commented Jun 9, 2016

Using a version of ember-scroll that's rewritten without dependency on trackpad-scroll-emulator jQuery Plugin.

display: flex;
flex-direction: column;

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove new line

@taras
Copy link
Collaborator Author

taras commented Jun 9, 2016

@offirgolan done!

@offirgolan
Copy link
Collaborator

@taras how come you removed ember-scrollable from peerDependencies?

@taras
Copy link
Collaborator Author

taras commented Jun 9, 2016

@offirgolan it was necessary before because ember-cli-node-assets requires this when used with 3 level deep dependencies (App -> ember-light-table -> ember-scrollable -> trackpad-scroll-emulator).

I eliminated trackpad-scroll-emulator as a dependency by rewriting it in Ember and moving all of the dependencies directly into ember-scrollable library.

@taras
Copy link
Collaborator Author

taras commented Jun 9, 2016

This is what the Ember version looks like https://github.com/alphasights/ember-scrollable/blob/master/addon/mixins/scrollable.js

@offirgolan
Copy link
Collaborator

@taras ah thats right. Awesome work :D

@offirgolan offirgolan merged commit e817369 into adopted-ember-addons:master Jun 9, 2016
@taras
Copy link
Collaborator Author

taras commented Jun 9, 2016

Thanks :)

HenryVonfire pushed a commit to HenryVonfire/ember-light-table that referenced this pull request Jun 27, 2016
* Using Ember native trackpad scroll emulator

* CSS tweaks to make it work correctly

* Removed white space and bumped ember-scrollable
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants