Using native Ember trackpad scroll emulator #40
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| display: flex; | ||
| flex-direction: column; | ||
|
|
|
@offirgolan done! |
|
@taras how come you removed ember-scrollable from |
|
@offirgolan it was necessary before because ember-cli-node-assets requires this when used with 3 level deep dependencies (App -> ember-light-table -> ember-scrollable -> trackpad-scroll-emulator). I eliminated |
|
This is what the Ember version looks like https://github.com/alphasights/ember-scrollable/blob/master/addon/mixins/scrollable.js |
|
@taras ah thats right. Awesome work :D |
|
Thanks :) |
HenryVonfire
pushed a commit
to HenryVonfire/ember-light-table
that referenced
this pull request
Jun 27, 2016
* Using Ember native trackpad scroll emulator * CSS tweaks to make it work correctly * Removed white space and bumped ember-scrollable
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using a version of ember-scroll that's rewritten without dependency on trackpad-scroll-emulator jQuery Plugin.