Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Edupi resource URL should be an URL #301

Closed
rgaudin opened this issue Jul 4, 2022 · 2 comments
Closed

Edupi resource URL should be an URL #301

rgaudin opened this issue Jul 4, 2022 · 2 comments
Assignees
Labels
bug Something isn't working

Comments

@rgaudin
Copy link
Member

rgaudin commented Jul 4, 2022

Almost never used the Edupi resource URI (which should be a ZIP file) apparently accepts any string (A user entered “wikipedia”) which would fail at the installer's download stage.

We should probably check that:

  • It's an URI
  • It's reachable at the time of addition (HEAD request)
@rgaudin rgaudin added the bug Something isn't working label Jul 4, 2022
@Popolechien
Copy link
Contributor

Popolechien commented May 10, 2024

Is this still a valid issue since we got rid of Edupi?

@rgaudin
Copy link
Member Author

rgaudin commented May 10, 2024

It's not valid, not because we got rid of edupi (we still allow pre-populated the filemanager) but because it's been implemented

@rgaudin rgaudin closed this as completed May 10, 2024
@rgaudin rgaudin self-assigned this May 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants