Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(gen): check schema for some cases which lead to stack overflow #306

Merged
merged 4 commits into from
Apr 23, 2022

Conversation

tdakkota
Copy link
Member

No description provided.

@codecov
Copy link

codecov bot commented Apr 22, 2022

Codecov Report

Merging #306 (0be677a) into main (9baedb6) will increase coverage by 0.02%.
The diff coverage is 77.50%.

@@            Coverage Diff             @@
##             main     #306      +/-   ##
==========================================
+ Coverage   66.87%   66.90%   +0.02%     
==========================================
  Files         117      117              
  Lines        7874     7874              
==========================================
+ Hits         5266     5268       +2     
+ Misses       2256     2254       -2     
  Partials      352      352              
Impacted Files Coverage Δ
tools/sgcollector/main.go 0.00% <0.00%> (ø)
gen/schema_gen_sum.go 82.70% <77.27%> (-0.09%) ⬇️
gen/schema_gen.go 79.04% <100.00%> (+0.82%) ⬆️
gen/reduce.go 65.71% <0.00%> (-8.58%) ⬇️
gen/ir/json.go 84.07% <0.00%> (+1.49%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9baedb6...0be677a. Read the comment docs.

@tdakkota tdakkota marked this pull request as ready for review April 22, 2022 20:47
@ernado ernado merged commit 72e1a32 into ogen-go:main Apr 23, 2022
@tdakkota tdakkota deleted the fix/infitie-recursion-detection branch April 23, 2022 10:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants