Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

authentication failure flow is not working properly #75

Closed
OhadR opened this issue Apr 20, 2017 · 1 comment
Closed

authentication failure flow is not working properly #75

OhadR opened this issue Apr 20, 2017 · 1 comment
Labels
bug duplicate

Comments

@OhadR
Copy link
Owner

OhadR commented Apr 20, 2017

when user fails to login, his counter of attempts does not decrease, and in the logs we see "... - login failed for user: null"

it happens because of #74 ; since I've upgraded Spring's version, Spring uses "username" rather than "j_username". Hence my AuthenticationFailureHandler could not get the username from the form, hence could not decrease his counter/lock, etc.
@OhadR
Copy link
Owner Author

OhadR commented Apr 20, 2017

closed as this is a technical duplication of #74 "delete AuthenticationFailureHandler.SPRING_SECURITY_FORM_USERNAME_KEY"

@OhadR OhadR closed this as completed Apr 20, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug duplicate
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@OhadR