Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Page Transition not triggering #8

Open
ohager opened this issue Jan 20, 2017 · 0 comments
Open

Page Transition not triggering #8

ohager opened this issue Jan 20, 2017 · 0 comments

Comments

@ohager
Copy link
Owner

ohager commented Jan 20, 2017

Under certain circumstances the transition does not trigger or stucks. I experience this mostly with Flux. A working solution seems to set the following routingImpl option.

const hiRouterOptions = {
		routingImpl: function(url){ setTimeout( () => this.props.history.push(url), 0 ); }
	};

ReactDOM.render(<HiRouter router={Router} options = {hiRouterOptions} />, document.getElementById('app-container'));

This kind of implementation should be default!

@ohager ohager changed the title Change default routing implementation to be async Page Transition not triggering Jan 20, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant