-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Return VTree from main #25
Merged
Merged
Changes from all commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
dbe03ae
use a proper main
eeue56 104cb4d
Update repository field
yusefnapora aa3bb43
Update NativeApp and Main to fix compile errors
yusefnapora 1d64354
ADTs for VTree & Property
yusefnapora 3d3b5ce
Render VTree type in native JS
yusefnapora de7a2d5
rm console logs
yusefnapora 78c3ac5
Add default case to vtreeToReactElement, throw if reached.
yusefnapora 7b3ba53
Cleanup + use ES5 for consistency.
yusefnapora 9dc74e2
comments for ReactNative.elm
yusefnapora 7d81bef
fix typo
yusefnapora 14c6929
Add instructions on compiler and core
ohanhi bfa6fb6
Merge pull request #1 from ohanhi/vtree-main-adt
yusefnapora File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,41 @@ | ||
'use strict'; | ||
var React = require('react-native'); | ||
var Elm = require('./elm'); | ||
var { | ||
AppRegistry, | ||
StyleSheet, | ||
Text, | ||
View, | ||
Image, | ||
} = React; | ||
|
||
|
||
function componentFactory() { | ||
return React.createClass({ | ||
componentWillMount() { | ||
Elm.embedReact(Elm.Main, this); | ||
}, | ||
getInitialState() { | ||
return { | ||
_elmVTree: React.createElement(View, {}, []), | ||
}; | ||
}, | ||
render() { | ||
var vtree = this.state._elmVTree; | ||
console.log('react app rendering vtree: ', vtree); | ||
return React.createElement(View, {style: styles.container}, | ||
vtree | ||
); | ||
}, | ||
}) | ||
} | ||
|
||
var styles = StyleSheet.create({ | ||
container: { | ||
flex: 1, | ||
justifyContent: 'center', | ||
alignItems: 'center', | ||
}, | ||
}); | ||
|
||
module.exports = componentFactory; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess we can use the same wrapper for both platforms all the time, yeah. There was a reason why we didn't do this straight in the beginning, though: usually bigger React Native apps have differences between iOS and Android versions. There are components that only work on iOS and vice versa. So in the long run, we should figure out a way to support this, maybe simply by having a
MainAndroid.elm
andMainIos.elm
, which would be compiled separately to e.g.elm.android.js
andelm.ios.js
.