Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature: Show Execution Time of the Running Job #8

Closed
palica opened this issue Nov 1, 2017 · 10 comments
Closed

Feature: Show Execution Time of the Running Job #8

palica opened this issue Nov 1, 2017 · 10 comments
Labels
enhancement
Milestone
0.5

Comments

@palica
Copy link
Contributor

palica commented Nov 1, 2017

Could the running jobs show the current execution time of the job?
@palica
Copy link
Contributor Author

palica commented Nov 6, 2017

It now shows cumulative time since last run.

Screenshot

@palica
Copy link
Contributor Author

palica commented Nov 6, 2017

it is also autorefreshing on the job detail page, but not on the jobs overview page.
So /jobs/portage/11 autorereshing
jobs/portage no autorefreshing and showing cumulative time for the finished builds

@palica
Copy link
Contributor Author

palica commented Nov 6, 2017

would it also be possible to show on the home page as the job is running the duration time, there where you display the last run info (Took 31s at 8:07 on Mon 6. Nov 2017)

@ohwgiles ohwgiles reopened this Nov 6, 2017
ohwgiles added a commit that referenced this issue Nov 6, 2017
@ohwgiles
calculate all duration in the client
116dfaa 
This cleans up some inconsistency where sometimes 'completed-started' happened
on the client side and sometimes on the server. Also should fix the 'cumulative
time' issue mentioned in #8
@ohwgiles
Copy link
Owner

ohwgiles commented Nov 6, 2017

It now shows cumulative time since last run.

Sorry, I introduced that with 7d47bc4, should be fixed with 116dfaa.

it is also autorefreshing on the job detail page, but not on the jobs overview page.

The Jobs page has never shown running jobs at all - that's issue #9. Or did I misunderstand?

would it also be possible to show on the home page as the job is running the duration time, there where you display the last run info (Took 31s at 8:07 on Mon 6. Nov 2017)

Yes, I'll add a follow-up commit for this

@ohwgiles
Copy link
Owner

ohwgiles commented Nov 6, 2017

Yes, I'll add a follow-up commit for this

Pushed, see 022aa0d

@ohwgiles ohwgiles mentioned this issue Nov 6, 2017
Closed
@palica
Copy link
Contributor Author

palica commented Nov 6, 2017

So /jobs/name-of-job/11 autorereshing the time counter
jobs/name-of-job not autorefreshing the time counter and showing cumulative time for the finished builds

@palica
Copy link
Contributor Author

palica commented Nov 6, 2017

to illustrate
https://postimg.org/image/6zzovvns5n/ here the duration changes (refreshes)
https://postimg.org/image/86vrinkhbf/ here is does not

ohwgiles added a commit that referenced this issue Nov 7, 2017
@ohwgiles
show active jobs on Jobs page
d3e4db1 
Rows on the jobs page now updated also during their execution. This
improvement was discussed in #8 and #9
ohwgiles added a commit that referenced this issue Nov 7, 2017
@ohwgiles
Dynamically update duration on job page
ce0a127 
Show dynamically updating duration for active jobs on the
job page. This adds to the resolution for #8
@ohwgiles
Copy link
Owner

ohwgiles commented Nov 7, 2017

This should be fixed now with ce0a127

@ohwgiles ohwgiles closed this as completed Nov 7, 2017
@palica
Copy link
Contributor Author

palica commented Nov 7, 2017

I see two rotating "running job indicators" now on the job detail page
https://postimg.org/image/1me6wjz9yj/

Everything else looks very good, thank you.

@ohwgiles
Copy link
Owner

ohwgiles commented Nov 7, 2017

The duplicated spinner should now be fixed with 298f72f.

@ohwgiles ohwgiles added this to the 0.5 milestone Dec 9, 2017
geraldolsribeiro pushed a commit to geraldolsribeiro/laminar that referenced this issue Nov 6, 2018
@ohwgiles
Dynamically update duration on job page
61136d8 
Show dynamically updating duration for active jobs on the
job page. This adds to the resolution for ohwgiles#8
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
0.5
Development

No branches or pull requests
2 participants
@ohwgiles @palica