Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

set up tests on Travis #4

Merged
merged 2 commits into from
Jan 22, 2018
Merged

set up tests on Travis #4

merged 2 commits into from
Jan 22, 2018

Conversation

callunity
Copy link
Collaborator

No description provided.

djcooke
djcooke approved these changes Jan 17, 2018
View reviewed changes
Copy link
Contributor

@djcooke djcooke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

npm install shows 70 missing dependency errors, and yet it runs fine... 🤔

@callunity
Copy link
Collaborator Author

Those dependency errors are all in nodemon, which is only used for local development (restarting the server every time a file changes). It runs fine on my machine and will never be used for testing or prod, so I think this is fine.

@callunity callunity merged commit 479f4cf into master Jan 22, 2018
@callunity callunity deleted the update_travis_with_tests branch January 22, 2018 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xuemeiluo xuemeiluo xuemeiluo approved these changes

@djcooke djcooke djcooke approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@callunity @xuemeiluo @djcooke