Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Share the article's DOI instead of the OJS link. #37

Closed
thiagolepidus opened this issue Jan 15, 2024 · 4 comments
Closed

Share the article's DOI instead of the OJS link. #37

thiagolepidus opened this issue Jan 15, 2024 · 4 comments

Comments

@thiagolepidus
Copy link

We had a request to share the DOI link instead of the OJS link, which has a higher probability of being changed over time. Integrating this functionality into the Shariff plugin seemed ideal to us. Can we submit a pull request with this feature?

We are considering three alternatives:

  1. If a DOI is available, the shared link will point to the DOI.
  2. Configurable option, maintaining the current default.
  3. Configurable option, setting the DOI link as the default.
@ronste
Copy link
Contributor

ronste commented Jan 16, 2024

Hi @thiagolepidus ,

that sounds good to me. You are very welcome to contribute.

Thanks,
Ronald

@thiagolepidus
Copy link
Author

Great, @ronste!

Do you have any preference among the suggested implementation alternatives?

@ronste
Copy link
Contributor

ronste commented Jan 17, 2024

Great, @ronste!

Do you have any preference among the suggested implementation alternatives?

Ohh, sorry. Forgot the alternatives. In the spirit of slowly adpating users to new features I would, for now, go with option 2). Once this is accepted we can make it the default, i.e. go for option 3).

Apart from that we have to consider that not all shareable object might have a DOI. In that case the Url should be sent.

@ronste
Copy link
Contributor

ronste commented Jan 19, 2024

@thiagolepidus ,

thanks for the PR. I will test it on my system, prepare a relase package and update the plugin gallery.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants