Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SPDX IDs #25

Merged
merged 15 commits into from
Dec 4, 2013
Merged

SPDX IDs #25

merged 15 commits into from
Dec 4, 2013

Conversation

enyst
Copy link
Contributor

@enyst enyst commented Dec 4, 2013

Switched to SPDX IDs for OSI approved licenses. File names also changed where necessary, however kept them all lowercase, to minimize changes this round.
Fixed a few other related bugs (Eiffel license, I believe, was duplicate, the BSD case had to be split). Added newer approved OSI licenses (last year or so), and updated data and scripts for consistency.
Removed the older named files and records about them.

I think the remaining question is:

  • should file names no longer be necessarily lowercase? Now it's a mix, though IMHO it's easy to work with, and I don't see a problem.

Notes:

  • there are no tests. I think current tests are obsolete since the OKFN service changed to raw data mostly, no longer built (probably 6714595). It's a bit difficult to figure out what exactly to test in raw data. :)
  • CC licenses not changed. Not sure they have to, because the service doesn't seem to have different versions, nor localized. Would versions be useful?

Should fix issue #24, locally tested. If redirections are necessary, and on github.io I guess it's not possible, we could re-add files with older names...

Signed-off-by: enyst <engel.nyst@gmail.com>
Signed-off-by: enyst <engel.nyst@gmail.com>
Signed-off-by: enyst <engel.nyst@gmail.com>
Signed-off-by: enyst <engel.nyst@gmail.com>
Signed-off-by: enyst <engel.nyst@gmail.com>
Signed-off-by: enyst <engel.nyst@gmail.com>
Newer named files are added. No removals
in this commit.

Signed-off-by: enyst <engel.nyst@gmail.com>
This commit is separate to revert easily,
if js callbacks are necessary and redirections
are not desired.

Signed-off-by: enyst <engel.nyst@gmail.com>
Signed-off-by: enyst <engel.nyst@gmail.com>
Signed-off-by: enyst <engel.nyst@gmail.com>
Signed-off-by: enyst <engel.nyst@gmail.com>
Case of IDs, spaces consistency in json, order of attributes,
fix bsl.

Signed-off-by: enyst <engel.nyst@gmail.com>
(scrape.py and app.js)
Also remove 'historical', it's not a category in OSI lists.

Signed-off-by: enyst <engel.nyst@gmail.com>
Signed-off-by: enyst <engel.nyst@gmail.com>
Regenerate files included.

Signed-off-by: enyst <engel.nyst@gmail.com>
mlinksva added a commit that referenced this pull request Dec 4, 2013
@mlinksva mlinksva merged commit ba0b4e3 into okfn:master Dec 4, 2013
@mlinksva
Copy link
Contributor

mlinksva commented Dec 4, 2013

I'd be fine with using SPDX case conventions throughout, including filenames. That's what I'd prefer, unless anyone objects, which is unlikely.

@mlinksva
Copy link
Contributor

mlinksva commented Dec 4, 2013

(Though I admit all lowercase looks pretty. I guess this is an admission that I have even less of an opinion than stated above.)

@enyst
Copy link
Contributor Author

enyst commented Dec 4, 2013

Well, all lowercase seemed very readable to me when working directly with the files. (Could it be because usual programming styles don't endorse much unrelated-to-words FiLENAminG? 😸. Even acronyms seem more predictable, or they're not often used.)

An example for the opposite choice, this is how it looks with almost-spdx names, respecting case. I like it too. Though there are currently fewer and well-known licenses in the list (so the comparison may not be entirely clear).

mlinksva added a commit that referenced this pull request Jan 15, 2018
except where:

1. rename is changing capitalization only, or
2. previous name was ambiguous (eg "apache" for "Apache-1.0")

might make sense to handle these cases a different way, if at all
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants