Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CellType.test doesn't return a Boolean value #1

Closed
timClicks opened this issue Aug 24, 2011 · 2 comments
Closed

CellType.test doesn't return a Boolean value #1

timClicks opened this issue Aug 24, 2011 · 2 comments

Comments

@timClicks
Copy link

I'm not quite sure how the API is intended to work, however I think CellType.test should return a Boolean. Currently, the default implementation returns the value or None.

The reason for this is I created a NullType(CellType) and NullType.test basically returned None or None. That behaviour makes it very difficult to use as a test.
@domoritz
Copy link
Contributor

domoritz commented Jan 4, 2013

Unfortunately there might be a BoolType. Can you use something other than None in you NullType?

@domoritz domoritz closed this as completed Jan 4, 2013
@domoritz
Copy link
Contributor

Okay, it might be a little bit late bit with #52, I rewrote the type guessing and test now returns a bool.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@timClicks @domoritz