Set peoples status through api #294
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
June 15, 2016 16:24
- This introduces a more flexible way of storing the "now doing" activities - Also extracts helpers into utils module - And adds tests
k-nut
changed the title
k-nut
changed the title
|
@pwalsh I think this is ready for a first review now. |
|
I'm deploying this to staging already to see if it works. |
|
Changes Unknown when pulling 4f82047 on 292-set-staff-member-statuses into * on master*. |
|
The last four commits clean up the code some more and add functional tests for the new |
|
If we merge #305 before this we need to change the migration to become number |
|
Assigning @pwalsh as this awaits review now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will collect the changes that are needed for making us more relatable.
It is work in progress right now but will fix #292
This goes hand in hand with the changes in okfns nice chatabot that is developed on the make-mowglibot-relatable branch.