[#304] Remove unused field from networkgroup #305
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Note that this PR and #294 both introduce migrations. Whatever is merged first should be referenced in the one that is merged after. |
k-nut
force-pushed
the
304-remove-unused-network-fields
branch
from
644eab9
to
b735809
Compare
|
Coverage decreased (-0.05%) to 86.145% when pulling b7358097190a13ba18ac57f342bcb1c579ba3d0a on 304-remove-unused-network-fields into 440f3d3 on master. |
|
@k-nut should I merge this, or you will change the migrations now? |
|
Hold of with merging this. I'll change the migration. |
added 2 commits
July 1, 2016 08:38
This removes three fields from `NetworkGroups` - youtube_url - wiki_url - gplus_url They were not used by any groups so it was decided that they can be dropped
k-nut
force-pushed
the
304-remove-unused-network-fields
branch
from
b735809
to
aed395c
Compare
|
@pwalsh I rebased this and changed the migration to be based upon the newly merged one. This should be good to go now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #304
This removes three fields from
NetworkGroupsThey were not used by any groups so it was decided that they can be
dropped