Change colors for the new buttons. #1
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
but maybe a css fix is better? PR is: joomla#5146 |
|
I'm OK with this except that, until now, there has been a hidden field with value |
|
We can't do this because it is a backwards compatibility break and what is probably more nagging me is that we have to translate the values for JLog again. I wasn't aware this was an existing feature and thus changing it would be more hassle than it is worth. The PLT has no issues keeping it as it is now. Let's close this one and merge joomla#5146. |
|
ok closing here. maybe we can add a code comment that we change the values with 4.0? @okonomiyaki3000 @roland-d |
okonomiyaki3000
pushed a commit
that referenced
this pull request
Jan 22, 2015
Allow only numbers in the count field
okonomiyaki3000
pushed a commit
that referenced
this pull request
Apr 27, 2015
Use token validation for com_installer update.ajax
okonomiyaki3000
pushed a commit
that referenced
this pull request
Sep 2, 2015
Just some very smal CS fixes.
okonomiyaki3000
pushed a commit
that referenced
this pull request
Nov 4, 2015
Fixing some very minor CS
okonomiyaki3000
pushed a commit
that referenced
this pull request
Nov 4, 2015
Code style + Improvement
okonomiyaki3000
pushed a commit
that referenced
this pull request
Nov 4, 2015
Just fixing the whitespace error
okonomiyaki3000
pushed a commit
that referenced
this pull request
Nov 4, 2015
Fix the issues mentiored by Travis and JM
okonomiyaki3000
pushed a commit
that referenced
this pull request
Nov 4, 2015
okonomiyaki3000
pushed a commit
that referenced
this pull request
Nov 4, 2015
CodeStyle two whitespaces ;)
okonomiyaki3000
pushed a commit
that referenced
this pull request
Jan 7, 2016
Making some database fields required
okonomiyaki3000
pushed a commit
that referenced
this pull request
Jan 7, 2016
Shuffle around the php-encryption library setup
okonomiyaki3000
pushed a commit
that referenced
this pull request
Jan 7, 2016
Allow to set an option to hide the Use default on helpsite field
okonomiyaki3000
pushed a commit
that referenced
this pull request
Apr 20, 2016
okonomiyaki3000
pushed a commit
that referenced
this pull request
Apr 20, 2016
Use IN instead of OR + code style
okonomiyaki3000
pushed a commit
that referenced
this pull request
Apr 20, 2016
Update en-GB.tpl_beez3.sys.ini
okonomiyaki3000
pushed a commit
that referenced
this pull request
May 19, 2016
Unit test loading behavior, don't explicitly import JFactory now
zero-24
pushed a commit
that referenced
this pull request
Jan 3, 2017
… (joomla#12290) * Cleanups, fixes and a bit of optimizations for site/components batch #1 - com_ajax - com_banners - com_config Note: This is a single commit bundling all types of changes, since PR joomla#12261 which had detailed commits, was rejected as a whole * Ch-Ch-Changes! * Removed the query changes * Fix for wrong merge resolve
zero-24
pushed a commit
that referenced
this pull request
Jan 3, 2017
…otes-in-administrator-no-1 Replace unnecessary double quotes in administrator #1
zero-24
pushed a commit
that referenced
this pull request
Jan 3, 2017
- removed senseless statements - one case correction - one loop optimization - removed a closing tag
zero-24
pushed a commit
that referenced
this pull request
Jan 3, 2017
Some improvements in tests #1:
okonomiyaki3000
pushed a commit
that referenced
this pull request
Jul 6, 2017
* Fixed callable call in loop termination condition * Fixed non-optimal regular expression * Shortened syntax for applied operations * Don't use strlen() to check if string is empty. * Reverted preg changes. Look into those later again. * Replaced call_user_func_array() with call_user_func() * Merge unset() calls * Replaced old intval() call with modern typecasting * Optimize away substr() as index-based access * Replace some cases of substr() with strpos() * Replace some stristr() with stripos() * Replace is_null() with null === ... * Removed unnecessary ternary operators * Fix for Juri... * Revert some changes for ... PHP5.3 compatibility * Make travis happy .... * Make codesniffer happy... * DYC! * Optimize non-optimal if conditions. * codsniffer... * Inline one-time use variables * Codesniffer... * Flipped comparisons `null === ...` to Joomla Style `... === null` `null !== ...` to Joomla Style `... !== null` * Flipped comparisons `false !== ...` to Joomla Style `... !== falsel` * Fix removal of ternary operator. Forgot inversion. * More flipping of comparisons ;) * Removed another unnecessary set of ternary operators. * Codesniffer... * Type-safe comparisons on strings * More type-safe comparisons * Changes that occurred during PR discussion * Remove some unnecessary parentheses * Removed empty if-group and reversed condition * Corrections on errors during merge (Conflict resolving) * Missed one. * Remove a parenthesis * Changes according to reviewer's comment * Revert change because of failure * Changes according to reviewer's comment + a few more changes found last minute * reversed change, though according to the method's doc that value should have been an integer... * Hopefully fixed... * Hopefully fixed... * Re-apply some changes
okonomiyaki3000
pushed a commit
that referenced
this pull request
Sep 14, 2018
Add missing string COM_PRIVACY_MSG_CONSENT_NO_CONSENT
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement:
Include -> Green
Exclude -> Red
@okonomiyaki3000 @roland-d