Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(objectarium): improve documentation #370

Merged
merged 1 commit into from
Sep 25, 2023
Merged

docs(objectarium): improve documentation #370

merged 1 commit into from
Sep 25, 2023

Conversation

ccamel
Copy link
Member

@ccamel ccamel commented Sep 22, 2023

Self explanatory.

NB: this is a first incremenent focused on the README. A second PR will come to cover the comment in the code.

@bot-anik
Copy link
Member

bot-anik commented Sep 22, 2023

size-limit report 📦

Path Size
target/wasm32-unknown-unknown/release/okp4_objectarium.wasm 426.3 KB (0%)
target/wasm32-unknown-unknown/release/okp4_law_stone.wasm 634.34 KB (0%)
target/wasm32-unknown-unknown/release/okp4_cognitarium.wasm 792.68 KB (0%)

@codecov
Copy link

codecov bot commented Sep 22, 2023

Codecov Report

Merging #370 (53f89b2) into main (706f037) will decrease coverage by 0.10%.
Report is 39 commits behind head on main.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #370      +/-   ##
==========================================
- Coverage   98.24%   98.14%   -0.10%     
==========================================
  Files          42       42              
  Lines        9847     9978     +131     
==========================================
+ Hits         9674     9793     +119     
- Misses        173      185      +12     

see 5 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@ccamel ccamel marked this pull request as ready for review September 25, 2023 07:29
@ccamel ccamel self-assigned this Sep 25, 2023
Copy link
Contributor

@bdeneux bdeneux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link
Member

@amimart amimart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link
Member

@MdechampG MdechampG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great thanks 🙏🏻

@ccamel ccamel merged commit 13c29a5 into main Sep 25, 2023
17 of 18 checks passed
@ccamel ccamel deleted the docs/improvements branch September 25, 2023 13:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants