Chore/core upgrades #463
Chore/core upgrades #463
Conversation
WalkthroughThe project has undergone a toolchain upgrade, with the Rust version advancing from 1.69 to 1.75. This update impacts the GitHub Actions workflows and the minimum Rust version requirement noted in the documentation. Additionally, there's been a refactoring in the Changes
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #463 +/- ##
==========================================
+ Coverage 96.80% 97.15% +0.35%
==========================================
Files 51 44 -7
Lines 10578 10590 +12
==========================================
+ Hits 10240 10289 +49
+ Misses 338 301 -37 ☔ View full report in Codecov by Sentry. |
size-limit report 📦
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Review Status
Actionable comments generated: 0
Configuration used: CodeRabbit UI
Files ignored due to path filters (7)
Cargo.lockis excluded by:!**/*.lockCargo.tomlis excluded by:!**/*.tomlMakefile.tomlis excluded by:!**/*.tomlcontracts/okp4-cognitarium/Cargo.tomlis excluded by:!**/*.tomlcontracts/okp4-dataverse/Cargo.tomlis excluded by:!**/*.tomlcontracts/okp4-law-stone/Cargo.tomlis excluded by:!**/*.tomlcontracts/okp4-objectarium/Cargo.tomlis excluded by:!**/*.toml
Files selected for processing (7)
- .github/workflows/build.yml (1 hunks)
- .github/workflows/lint.yml (8 hunks)
- .github/workflows/release.yml (1 hunks)
- .github/workflows/test.yml (1 hunks)
- README.md (1 hunks)
- contracts/okp4-cognitarium/src/querier/mod.rs (1 hunks)
- packages/okp4-rdf/src/normalize.rs (1 hunks)
Files skipped from review due to trivial changes (1)
- .github/workflows/lint.yml
Additional comments: 6
contracts/okp4-cognitarium/src/querier/mod.rs (1)
- 5-8: > 📝 NOTE
This review was outside the diff hunks and was mapped to the diff hunk with the greatest overlap. Original lines [1-7]
The
planmodule has been removed from the public exports, and theplan_buildermodule has been added. This change in the module's public API should be verified to ensure that it does not break any existing functionality that depends on theplanmodule.Verification successful
The search for external usage of the
planmodule outside thequerierdirectory did not yield any results. This suggests that theplanmodule is not used outside of thequerierdirectory, and its removal from public exports is unlikely to affect other parts of the codebase.Given this information, it appears that the change in the module's public API, specifically the removal of the
planmodule from public exports and the addition of theplan_buildermodule, does not break any existing functionality outside of theokp4-cognitariumcontract.Scripts Executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Search for usage of the `plan` module in the codebase to ensure no breaking changes. rg --type rust "plan::" # Search for the `plan_builder` module to ensure it is being used correctly. rg --type rust "plan_builder::"Length of output: 358
Script:
#!/bin/bash # Search for external usage of the `plan` module outside the `querier` directory to ensure no breaking changes. rg --type rust --glob '!contracts/okp4-cognitarium/src/querier/*' "plan::"Length of output: 74
.github/workflows/build.yml (1)
- 37-37: The Rust toolchain version has been updated to 1.75. This change is consistent with the PR objectives and should not pose any issues as long as all Rust code in the project is compatible with the new version.
.github/workflows/test.yml (1)
- 37-37: The Rust toolchain version has been updated to 1.75 in the test workflow. This change is consistent with the PR objectives and should not pose any issues as long as all Rust code in the project is compatible with the new version.
.github/workflows/release.yml (1)
- 49-49: The Rust toolchain version has been updated to 1.75 in the release workflow. This change is consistent with the PR objectives and should not pose any issues as long as all Rust code in the project is compatible with the new version.
README.md (1)
- 204-204: The minimum required version of Rust has been updated to 1.75 in the README. This change is consistent with the PR objectives and should not pose any issues as long as it is communicated to developers who may need to update their local Rust installations.
packages/okp4-rdf/src/normalize.rs (1)
- 114-114: The
get(0)method call has been replaced withfirst()within themapfunction. This is a more idiomatic way to access the first element of a collection in Rust and should not change the logic as both methods are functionally equivalent in this context.
Refresh core dependencies following new okp4d version.
Details
Cosmwasm dependencies have been upgraded to the latest available version, making the possibilities to switch the rust version to
1.75.Because of changes in Cosmos SDK genesis commands, some recipes used to manage a localnet in the makefile have been updated to work with okp4d
v6.0.0.Caveats
It's maybe due to these changes, or not, contracts are growing and the produced
cognitariumwasm is too heavy to be stored on-chain with the defaultwasmmodule settings. We could gain a lot regarding this by using the rust-optimizer to build released artefacts, I'll open an issue for that and propose this merge this PR as is.Summary by CodeRabbit
Documentation
New Features
plan_buildermodule for improved query planning.Refactor