Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ignore empty __init__.py when constructing test map #413

Merged
merged 2 commits into from
Apr 12, 2020
Merged

Ignore empty __init__.py when constructing test map #413

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a89b8db
Ignore empty __init__.py when constructing test map
kavigupta Apr 11, 2020
b3342ca
just whitespace is empty
kavigupta Apr 12, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions client/api/assignment.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -181,6 +181,15 @@ def get_student_email(self):
def get_identifier(self):
return auth.get_identifier(self.cmd_args, endpoint=self.endpoint)

def is_empty_init(self, path):
if os.path.basename(path) != '__init__.py':
return False

with open(path) as f:
contents = f.read()

return contents.strip() == ""

def _load_tests(self):
"""Loads all tests specified by test_map."""
log.info('Loading tests')
Expand All @@ -193,6 +202,8 @@ def _load_tests(self):
parameter = ''

for file in sorted(glob.glob(file_pattern)):
if self.is_empty_init(file):
continue
try:
module = importlib.import_module(self._TESTS_PACKAGE + '.' + source)
except ImportError:
Expand Down