Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add & update configuration guards #32

Closed
8 tasks
nbarbettini opened this issue Aug 27, 2018 · 0 comments
Closed
8 tasks

Add & update configuration guards #32

nbarbettini opened this issue Aug 27, 2018 · 0 comments
Assignees
@laura-rodriguez
Labels
enhancement New feature or request In Progress

Comments

@nbarbettini
Copy link
Contributor

From https://oktawiki.atlassian.net/wiki/spaces/PM/pages/552049922/Proposal+configuration+copypasta+guard

  • OktaDomain is null or empty
  • OktaDomain contains {yourOktaDomain}
  • OktaDomain contains -admin.okta.com, -admin.oktapreview.com, or -admin.okta-emea.com
  • OktaDomain ends with .com.com
  • Client ID is null or empty
  • Client ID contains {clientId}

For Okta.MvcOptions:

  • Client secret is null or empty
  • Client secret contains {clientSecret}

Some of these are implemented already, but we need to update the error messages to the new error strings mentioned in the wiki.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@laura-rodriguez laura-rodriguez

Labels
enhancement New feature or request In Progress
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@nbarbettini @tombritton-okta @laura-rodriguez