Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make tokenManager.get() asynchronous #125

Closed
robertjd opened this issue Jun 6, 2018 · 1 comment
Closed

Make tokenManager.get() asynchronous #125

robertjd opened this issue Jun 6, 2018 · 1 comment
Assignees
@jmelberg-okta
Labels
Published
Milestone
AuthJS 2.0

Comments

@robertjd
Copy link
Contributor

robertjd commented Jun 6, 2018

This method is currently synchronous, and creates problems if the token is being refreshed at the time that this method is called. This problem has been discussed at length in these issues:

#92
#123
okta/okta-oidc-js#181

The desired fix is described in this comment:

okta/okta-oidc-js#181 (comment)

We are going to implement this fix and release a major version. Please watch this issue for updates.
@robertjd robertjd mentioned this issue Jun 7, 2018
Closed
@robertjd robertjd changed the title Make token.get() asynchronous Make tokenManager.get() asynchronous Jun 7, 2018
@jmelberg-okta jmelberg-okta mentioned this issue Jun 18, 2018
Merged
@jmelberg-okta jmelberg-okta added this to the AuthJS 2.0 milestone Jun 18, 2018
@jmelberg-okta jmelberg-okta mentioned this issue Jun 18, 2018
Closed
@hotgazpacho hotgazpacho mentioned this issue Aug 1, 2018
Closed
@jmelberg-okta
Copy link
Contributor

Resolved with 2.0.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jmelberg-okta jmelberg-okta

Labels
Published
Projects
None yet
Milestone
AuthJS 2.0
Development

No branches or pull requests
3 participants
@robertjd @jmelberg-okta @robertdamphousse-okta