Updates package.json in all packages to run e2e scripts #359
Conversation
vijetmahabaleshwar-okta
force-pushed
the
vm-fix-package
branch
11 times, most recently
from
aa73bdf
to
612be90
Compare
vijetmahabaleshwar-okta
force-pushed
the
vm-fix-package
branch
from
612be90
to
de56d3b
Compare
vijetmahabaleshwar-okta
changed the title
vijetmahabaleshwar-okta
changed the title
vijetmahabaleshwar-okta
requested review from
jmelberg-okta and
robertdamphousse-okta
packages/okta-angular/package.json
Outdated
| "test:e2e": "yarn --cwd test/e2e/harness/ e2e", | ||
| "test": "yarn lint && yarn e2e && yarn test:unit", | ||
| "pree2e": "yarn build:dependencies", | ||
| "e2e": "yarn --cwd test/e2e/harness/ e2e", |
There was a problem hiding this comment.
Any reason to change this from test:e2e to e2e throughout all of these package updates? By doing so, we're losing out on the naming convention of test:${type} laid out across this monorepo.
There was a problem hiding this comment.
I wanted pree2e script to run automatically since we won't be able to run yarn test:e2e without first running yarn pretest.
The general convention in the yarn world I believe is to have e2e and pree2e scripts.
This is needed for running the e2e tests on bacon.
I could instead do yarn pretest; yarn test:e2e but running yarn e2e alone seemed cleaner.
| @@ -33,7 +33,7 @@ module.exports = { | |||
| javascriptEnabled: true, | |||
| acceptSslCerts: true, | |||
| chromeOptions: { | |||
| args: ['--disable-gpu --no-sandbox --headless --window-size=1920,1080 --verbose --disable-dev-shm-usage'] | |||
| args: ['--no-sandbox'] | |||
There was a problem hiding this comment.
Do we want to bring back the --headless flag here?
There was a problem hiding this comment.
For some reason, having --headless crashes the chrome on bacon. I have seen a stackoverflow thread talking about the same. Works on travis as well. And locally, it's nice to be able to see the browser in action.
vijetmahabaleshwar-okta
force-pushed
the
vm-fix-package
branch
from
5a0dab5
to
29d24cd
Compare
vijetmahabaleshwar-okta
force-pushed
the
vm-fix-package
branch
from
29d24cd
to
aad773d
Compare
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: N/A
What is the new behavior?
Removes dependency on certain version of chrome driver to run tests
Does this PR introduce a breaking change?
Other information
Reviewers