Revert pipeline skipifexists okteto global #1958
Conversation
|
Thank you for your contribution. unfortunately, one or more of your commits are missing the required "Signed-off-by:" statement. Signing off is part of the Developer Certificate of Origin (DCO) which is used by this project. Read the DCO and project contributing guide carefully, and amend your commits using the git CLI. Note that this does not require any cryptography, keys or special steps to be taken. 💡 Shall we fix this?This will only take a few moments. First, clone your fork and checkout this branch using the git CLI. Next, set up your real name and email address:
Finally, run one of these commands to add the "Signed-off-by" line to your commits. If you only have one commit so far then run: Check that the message has been added properly by running "git log". |
Codecov Report
@@ Coverage Diff @@
## master #1958 +/- ##
==========================================
+ Coverage 33.46% 33.49% +0.02%
==========================================
Files 123 123
Lines 13873 13857 -16
==========================================
- Hits 4643 4641 -2
+ Misses 8728 8714 -14
Partials 502 502
Continue to review full report at Codecov.
|
pkg/cmd/build/build.go
Outdated
| } | ||
| return nil | ||
| } | ||
|
|
||
| // buildWithOkteto build and pushes the image to the registry, if skipped will return bool true, if error, will return error | ||
| func buildWithOkteto(ctx context.Context, buildOptions BuildOptions) (bool, error) { | ||
| func buildWithOkteto(ctx context.Context, namespace string, buildOptions BuildOptions) error { |
There was a problem hiding this comment.
I think namespace parameter is not being used in the function
pkg/cmd/build/build.go
Outdated
| @@ -43,59 +43,43 @@ type BuildOptions struct { | |||
| } | |||
|
|
|||
| // Run runs the build sequence | |||
| func Run(ctx context.Context, buildOptions BuildOptions) error { | |||
| func Run(ctx context.Context, namespace string, buildOptions BuildOptions) error { | |||
There was a problem hiding this comment.
I think that namespace could be removed also from here if buildWithOkteto doesn't need it
Signed-off-by: Teresa Romero <teresa@okteto.com>
teresaromero
deleted the
tere/revert-pipeline-skipifexists-okteto-global
branch
Fixes https://github.com/okteto/app/issues/2960
Proposed changes