Check deployed dev environments when inferring the name

[ifbyol]

Fixes #3276

Proposed changes

Modified the logic of the function InferName to use the following preference for inferring the name:

1. Name specified with the --name flag
2. Name specified in the manifest
3. Name specified in a deployed dev environment matching the repository URL + manifest path (the new scenario we are adding)
4. Name extracted from the repo URL of the working directory
5. Name extracted from the folder name of the working directory

The first 2 cases are handled directly by any commands and if no name is found, a call to the function InferName is being done for the rest of scenarios.

In this PR I'm adding the scenario number 3 within the InferName function.

Apart from that, I've moved the InferName function to a new package.

Finally, I added also a flag --name to the logs command

Some concerns I have (cc @pchico83):

1. It might happen that the same repository with the same manifest path is deployed with different name. What should we do in this case? For now, I'm just taking the first one
2. In the way we handle the namespace involved in each command is different and it is hard to know the one we should use. All my testing and checking the code points that using okteto.Context().Namespace should be ok but there are cases which is very confusing. For example, here it might happen that options.Namespace has the manfest.Namespace value, but has okteto.Context().Namespace the same value?

In any case, I'm always defaulting to previous behavior, so in the worts case scenario there would be still cases in which this keeps behaving in the way the ticket reports.

I think that we should unify how the namespace and those things are initialized in the commands.

Just a note to bear in mind, the first commit contains the refactor to move the InferName. You can check it here.

[pchico83]

@ifbyol about this one:

It might happen that the same repository with the same manifest path is deployed with different name. What should we do in this case? For now, I'm just taking the first one

Let's pick the first one and show an info message

[derek]

Thank you for your contribution. unfortunately, one or more of your commits are missing the required "Signed-off-by:" statement. Signing off is part of the Developer Certificate of Origin (DCO) which is used by this project.

Read the DCO and project contributing guide carefully, and amend your commits using the git CLI. Note that this does not require any cryptography, keys or special steps to be taken.

💡 Shall we fix this?

This will only take a few moments.

First, clone your fork and checkout this branch using the git CLI.

Next, set up your real name and email address:

git config --global user.name "Your Full Name"
git config --global user.email "you@domain.com"

Finally, run one of these commands to add the "Signed-off-by" line to your commits.

If you only have one commit so far then run: git commit --amend --signoff and then git push --force.
If you have multiple commits, watch this video.

Check that the message has been added properly by running "git log".

[ifbyol]

After talking offline with @pchico83 , I'm leaving our of the scope of this PR the modification of getStackName function. It requires a bigger refactor. It affects when the repository has only a docker-compose.yaml or okteto-stack.yaml. In those cases, we won't infer the name from the dev environments deployed in the namespace. Most of the commands have the --name flag to cover the case.

[ifbyol]

Moved to a new package in this commit d95d8c1

[teresaromero]

LGTM. Nice comments and refactor of infer name, this will add more clarity :)

[jLopezbarb]

After talking offline with @pchico83 , I'm leaving our of the scope of this PR the modification of getStackName function. It requires a bigger refactor. It affects when the repository has only a docker-compose.yaml or okteto-stack.yaml. In those cases, we won't infer the name from the dev environments deployed in the namespace. Most of the commands have the --name flag to cover the case.

Code looks good👏👏 !! Can we create an issue to tackle this in the future, or at least taking it in consideration whenever we refactor/tweak those files

[ifbyol]

@teresaromero @jLopezbarb can you double check the lat commit? I had to add some of the logic in the pipeline deploy and destroy commands as they are not using the InferName function

[ifbyol]

After talking offline with @pchico83 , I'm leaving our of the scope of this PR the modification of getStackName function. It requires a bigger refactor. It affects when the repository has only a docker-compose.yaml or okteto-stack.yaml. In those cases, we won't infer the name from the dev environments deployed in the namespace. Most of the commands have the --name flag to cover the case.

Code looks good👏👏 !! Can we create an issue to tackle this in the future, or at least taking it in consideration whenever we refactor/tweak those files

@jLopezbarb Ticket created! #3311

[github-actions]

This pull request is stale because it has been open for 15 days with no activity. Comment on this pull request or it will be closed in 7 days

[ifbyol]

e2e tests are passing so I'll merge it!