Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport release-2.16] fix: variable expansion on buildargs that only have one env #3691

Merged
merged 3 commits into from Jun 2, 2023

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Jun 1, 2023

Backport 0727f25 from #3689.

Signed-off-by: Javier López Barba <javier@okteto.com>
(cherry picked from commit 0727f25)
@github-actions github-actions bot requested a review from a team June 1, 2023 15:21
@derek derek bot added the new-contributor label Jun 1, 2023
Signed-off-by: Javier López Barba <javier@okteto.com>
@jLopezbarb
Copy link
Contributor

Needed a commit because #3635 is missing in the 2.16 branch

@derek derek bot added the no-dco label Jun 2, 2023
@derek
Copy link

derek bot commented Jun 2, 2023

Thank you for your contribution. unfortunately, one or more of your commits are missing the required "Signed-off-by:" statement. Signing off is part of the Developer Certificate of Origin (DCO) which is used by this project.

Read the DCO and project contributing guide carefully, and amend your commits using the git CLI. Note that this does not require any cryptography, keys or special steps to be taken.

💡 Shall we fix this?

This will only take a few moments.

First, clone your fork and checkout this branch using the git CLI.

Next, set up your real name and email address:

git config --global user.name "Your Full Name"
git config --global user.email "you@domain.com"

Finally, run one of these commands to add the "Signed-off-by" line to your commits.

If you only have one commit so far then run: git commit --amend --signoff and then git push --force.
If you have multiple commits, watch this video.

Check that the message has been added properly by running "git log".

@jLopezbarb jLopezbarb merged commit 9f680c5 into release-2.16 Jun 2, 2023
10 of 11 checks passed
@jLopezbarb jLopezbarb deleted the backport-3689-to-release-2.16 branch June 2, 2023 10:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants