Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove secret content from build hash #3635

Merged
merged 1 commit into from
May 29, 2023

Conversation

sankalp-r
Copy link
Contributor

Proposed changes

Fixes #3622

Please include a summary of the changes and the related issue. Please also include relevant motivation and context. List any dependencies that are required for this change.

@sankalp-r sankalp-r requested a review from a team May 19, 2023 12:03
@sankalp-r
Copy link
Contributor Author

@jLopezbarb Please have a look when you have time.

@jLopezbarb
Copy link
Contributor

@sankalp-r I tested it and it's working perfectly 😉. Thanks for the addition

Copy link
Contributor

@AdrianPedriza AdrianPedriza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great work! :)

cmd/build/v2/config.go Show resolved Hide resolved
Signed-off-by: Sankalp Rangare <sankalprangare786@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Build hash should not check secret content to create it
3 participants