fix: clean manifest path in remote deploy to fix regression

[andreafalzetti]

Proposed changes

Fixes DEV-199

How to validate

1. Clone my test repo on the given branch: git clone -b fix-dev-199 git@github.com:andreafalzetti/k8s-status-api.git
2. Using the 2.25.1 reproduce the bug by running: okteto up --deploy -f apps/service/okteto.yml
3. Observe the error: Okteto.yml file doesn't exist
4. Now run the same command with the CLI from this branch
5. Notice how the okteto up session, works as expected

Repeat the steps for destroy and make sure it works as expected

CLI Quality Reminders 🔧

For both authors and reviewers:

• Scrutinize for potential regressions
• Ensure key automated tests are in place
• Build the CLI and test using the validation steps
• Assess Developer Experience impact (log messages, performances, etc)
• If too broad, consider breaking into smaller PRs
• Adhere to our code style and code review guidelines

[codecov]

Codecov Report

Merging #4195 (a88af29) into master (fb49fc0) will decrease coverage by 0.04%.
The diff coverage is 83.33%.

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #4195      +/-   ##
==========================================
- Coverage   45.71%   45.68%   -0.04%     
==========================================
  Files         291      292       +1     
  Lines       27198    27194       -4     
==========================================
- Hits        12434    12424      -10     
- Misses      13676    13680       +4     
- Partials     1088     1090       +2     

[ifbyol]

We need to have that logic also in the destroy. Check my inline comment

[ifbyol]

Should we add this same logic in the destroy? If the destroy has some commands to be executed, it won't execute them, but the dev-environment will be deleted.

I have tested it adding this to your example:

destroy:
  remote: true
  commands:
    - echo "Hello world"

If you execute okteto destroy -f apps/service/okteto.yml, it doesn't run the echo command

[andreafalzetti]

@ifbyol good point, I've made the changes for destroy and moved the cleanManifestPath to a shared place. Can you please have another go at the review?

[github-actions]

The backport to release-2.25 failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-release-2.25 release-2.25
# Navigate to the new working tree
cd .worktrees/backport-release-2.25
# Create a new branch
git switch --create backport-4195-to-release-2.25
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 e568f2a875384e705af5adec861b667f048f8706
# Push it to GitHub
git push --set-upstream origin backport-4195-to-release-2.25
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-release-2.25

Then, create a pull request where the base branch is release-2.25 and the compare/head branch is backport-4195-to-release-2.25.