-
Notifications
You must be signed in to change notification settings - Fork 311
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Backport][2.25] Manifest path fixes for remote deploy #4201
Conversation
Signed-off-by: Andrea Falzetti <andrea@okteto.com>
--------- Signed-off-by: Andrea Falzetti <andrea@okteto.com>
Signed-off-by: Andrea Falzetti <andrea@okteto.com>
7ff3292
to
51b5e84
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## release-2.25 #4201 +/- ##
================================================
+ Coverage 45.56% 45.62% +0.05%
================================================
Files 287 288 +1
Lines 27057 27094 +37
================================================
+ Hits 12329 12362 +33
- Misses 13642 13644 +2
- Partials 1086 1088 +2 |
Signed-off-by: Andrea Falzetti <andrea@okteto.com>
Signed-off-by: Andrea Falzetti <andrea@okteto.com>
Signed-off-by: Andrea Falzetti <andrea@okteto.com>
Signed-off-by: Andrea Falzetti <andrea@okteto.com>
46043b1
to
cb50024
Compare
2.25
manifest path fixThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
馃憦
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested all the scenarios.
I created a new scenario that is not covered but it was also not working in 2.25.0
.
From apps/service/pkg
okteto deploy -f ../.okteto/okteto.yml --remote
Signed-off-by: Andrea Falzetti <andrea@okteto.com>
@jLopezbarb good catch! I've fixed the additional case and re-tested all 34 scenarios using the "script". It works for all listed cases now. I will wait for the CI tests to pass, and merge. Thanks both @ifbyol and @jLopezbarb for your help in testing and reviewing this PR 馃檹 |
Proposed changes
This PR is a manual backport to release
2.25
of the following:okteto deploy -f <parent>/okteto.yml
okteto deploy -f <dir>
How to validate
git clone -b fix-dev-199 git@github.com:andreafalzetti/k8s-status-api.git
DEPLOY
DESTROY
A quick way of testing all scenarios is run these 4 batches:
CLI Quality Reminders 馃敡
For both authors and reviewers: