-
Notifications
You must be signed in to change notification settings - Fork 314
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
report upload progress #424
Conversation
cmd/up.go
Outdated
up.updateStateFile(synchronizing) | ||
progress.start() | ||
defer progress.stop() | ||
|
||
if err := up.Sy.WaitForCompletion(up.Context, up.WG, up.Dev); err != nil { | ||
reporter := make(chan float64, 0) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
S1019: should use make(chan float64) instead (from gosimple
)
1a92738
to
2b413a2
Compare
cmd/up.go
Outdated
for c := range reporter { | ||
if c > previous { | ||
// todo: how to calculate how many characters can the line fit? | ||
p := fmt.Sprintf(postfix) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
SA1006: printf-style function with dynamic first argument and no further arguments should use print-style function instead (from staticcheck
)
6c2666b
to
2bfbe86
Compare
This solves part of #352