-
Notifications
You must be signed in to change notification settings - Fork 311
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: deprecate compose file detection by naming #4254
Conversation
Signed-off-by: Javier Lopez <javier@okteto.com>
Signed-off-by: Javier Lopez <javier@okteto.com>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #4254 +/- ##
==========================================
- Coverage 45.58% 45.55% -0.03%
==========================================
Files 305 305
Lines 27602 27612 +10
==========================================
- Hits 12583 12580 -3
- Misses 13944 13953 +9
- Partials 1075 1079 +4 |
Signed-off-by: Javier Lopez <javier@okteto.com>
Signed-off-by: Javier Lopez <javier@okteto.com>
Signed-off-by: Javier Lopez <javier@okteto.com>
Signed-off-by: Javier Lopez <javier@okteto.com>
Signed-off-by: Javier Lopez <javier@okteto.com>
pkg/model/stack.go
Outdated
return true | ||
} | ||
if !isComposeFileName { | ||
oktetoLog.Warning("okteto stack syntax is deprecated. Please consider migrating to compose syntax: https://community.okteto.com/t/important-update-migrating-from-okteto-stacks-to-docker-compose/1262") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oktetoLog.Warning("okteto stack syntax is deprecated. Please consider migrating to compose syntax: https://community.okteto.com/t/important-update-migrating-from-okteto-stacks-to-docker-compose/1262") | |
oktetoLog.Warning("Okteto Stack syntax is deprecated. Please consider migrating to Docker Compose syntax: https://community.okteto.com/t/important-update-migrating-from-okteto-stacks-to-docker-compose/1262") |
Also, could you share a screenshot? Maybe it looks better with a new line after "Okteto Stack syntax is deprecated"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Signed-off-by: Javier Lopez <javier@okteto.com>
Proposed changes
Partly fixes DEV-248.
We are deprecating the detection of a compose or stack file based on the name of the file. Now the users will have to use
OKTETO_SUPPORT_STACKS_ENABLED=true
in order to have previous behaviour.OKTETO_SUPPORT_STACKS_ENABLED
(Documentation PR/Stack vs Compose community post)How to validate
docker-compose.yml
tostack.yml
okteto deploy
CLI Quality Reminders 馃敡
For both authors and reviewers: