Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: not show unwanted warning #4282

Merged
merged 1 commit into from
May 8, 2024

Conversation

jLopezbarb
Copy link
Contributor

Proposed changes

While doing the release manual testing we discovered that there was an unwanted warning caused by #4254

Given the current implementation the only way to not show that warning was to calculate if the file was a Dockerfile before checking if it was an okteto manifest or a compose/stack file.

How to validate

  1. Run okteto build -f Dockerfile on a file that is a valid Dockerfile and check that the warning is not shown

CLI Quality Reminders 🔧

For both authors and reviewers:

  • Scrutinize for potential regressions
  • Ensure key automated tests are in place
  • Build the CLI and test using the validation steps
  • Assess Developer Experience impact (log messages, performances, etc)
  • If too broad, consider breaking into smaller PRs
  • Adhere to our code style and code review guidelines

Signed-off-by: Javier Lopez <javier@okteto.com>
@jLopezbarb jLopezbarb requested a review from a team as a code owner May 7, 2024 15:10
@jLopezbarb jLopezbarb added release/bug-fix backport release-2.27 Backport this PR to CLI version 2.27 labels May 7, 2024
Copy link

codecov bot commented May 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 43.37%. Comparing base (535fdf3) to head (a5be81c).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #4282   +/-   ##
=======================================
  Coverage   43.37%   43.37%           
=======================================
  Files         368      368           
  Lines       30012    30015    +3     
=======================================
+ Hits        13017    13020    +3     
  Misses      15876    15876           
  Partials     1119     1119           

@andreafalzetti andreafalzetti merged commit eef4ad5 into master May 8, 2024
21 of 22 checks passed
@andreafalzetti andreafalzetti deleted the jlo/fix-unwanted-warning-for-build branch May 8, 2024 12:03
github-actions bot pushed a commit that referenced this pull request May 8, 2024
Signed-off-by: Javier Lopez <javier@okteto.com>
(cherry picked from commit eef4ad5)
andreafalzetti pushed a commit that referenced this pull request May 8, 2024
Signed-off-by: Javier Lopez <javier@okteto.com>
(cherry picked from commit eef4ad5)

Co-authored-by: Javier López Barba <javier@okteto.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport release-2.27 Backport this PR to CLI version 2.27 release/bug-fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants