Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: Connect device via WiFi #99

Open
luisbytes opened this issue Nov 16, 2023 · 11 comments
Open

Feat: Connect device via WiFi #99

luisbytes opened this issue Nov 16, 2023 · 11 comments
Labels
enhancement New feature or request

Comments

@luisbytes
Copy link

It would be great if you could connect an Android v11+ device over WiFi by scanning the a QR Code just like Android Studio has it.

@okwasniewski okwasniewski added the enhancement New feature or request label Nov 20, 2023
@gokul1099
Copy link
Contributor

@okwasniewski Shall I work on this

@okwasniewski
Copy link
Owner

Hey, thanks for opening a new feature request. MiniSim focuses on emulators and does not connect / display real devices. That's something worth considering in the future but firstly we would need to support connecting the device through USB. Also, the QR Code scanning might be exclusive to Android Studio and we would need to reimplement it. So let's keep this issue open but it could be worked on only after implementing USB devices support.

@gokul1099 If you want to you can work on adding support for USB devices (or take something else).

@gokul1099
Copy link
Contributor

@okwasniewski Ok, I will work on some other issue. Can you explain that USB devices support feature? or is there any separate issue raised for that??

@okwasniewski
Copy link
Owner

I will open a more detailed issue explaining what should be done to support this feature. For now let's focus on something else

@luisbytes
Copy link
Author

Hi I don't have all the technical knowledge, but I think it is not an exclusive functionality of Android Studio. It generates a QR code this has an information that occupies ADB.

Here is an implementation with node
https://github.com/saleehk/adb-wifi/blob/master/src/index.js

@gokul1099
Copy link
Contributor

Hi I don't have all the technical knowledge, but I think it is not an exclusive functionality of Android Studio. It generates a QR code this has an information that occupies ADB.

Here is an implementation with node saleehk/adb-wifi@master/src/index.js

Yes, its a great plugin, I am using this for a long time, this works perfectly. I have also gone through implementation. It will be great if will add this to minisim.

@okwasniewski
Copy link
Owner

Thanks for sending! I wasn't aware of that in that case it looks like this feature can be added to MiniSIm

@gokul1099
Copy link
Contributor

@okwasniewski Shall i work on this ??

@okwasniewski
Copy link
Owner

@gokul1099 Sure, you can! However I think firstly it would be best to tackle #112 to finish that feature

@gokul1099
Copy link
Contributor

@gokul1099 Sure, you can! However I think firstly it would be best to tackle #112 to finish that feature

Ok let me try to fix that first

@okwasniewski
Copy link
Owner

Now that #122 has landed this can be revisited 👍🏻

cc: @gokul1099

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants