Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unmatched Sound Mode #67

Closed
lviperz opened this issue Nov 20, 2018 · 6 comments
Closed

Unmatched Sound Mode #67

lviperz opened this issue Nov 20, 2018 · 6 comments

Comments

@lviperz
Copy link

lviperz commented Nov 20, 2018

WARNING (Thread-10) [DenonAVR] Not able to match sound mode: 'Dolby Digital + Neural:X', returning raw sound mode.

I used to get no match for Dolby D + Neural:X before 0.7.6. Since I updated HA to 82.1 which included 0.7.6 I'm now getting unmatched for Dolby Digital + Neural:X

I thought about changing line 50, Dolby D to Dolby Digital.

@starkillerOG
Copy link
Contributor

@lviperz yes you are right, you have a varient of the sound mode that is not yet included in the matching dictionary. Yust add "Dolby Digital + Neural:X" behind "Dolby D + Neural:X".
I will include this in my PR, to fix it in a future release.

@starkillerOG
Copy link
Contributor

@lviperz I fixed it in this PR: #66.
You can see how I added it to the sound mode dictionary to fix it for yourself, or you can just wait untill the PR gets merged and HomeAssistant gets updated.

@lviperz
Copy link
Author

lviperz commented Nov 28, 2018

Thank you. I also added the following.

'DOLBY DIGITAL + + NEURAL:X'

@starkillerOG
Copy link
Contributor

@lviperz, I also included 'DOLBY DIGITAL + + NEURAL:X' in the PR.

@starkillerOG
Copy link
Contributor

@scarface-4711 This issue can be closed, with the merge of #66 this is now fixed.

@ol-iver
Copy link
Owner

ol-iver commented Dec 2, 2018

great :)

@ol-iver ol-iver closed this as completed Dec 2, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants