Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Morning session: Peer-to-peer code review #8

Open
rachidelaid opened this issue Jan 19, 2022 · 0 comments
Open

Morning session: Peer-to-peer code review #8

rachidelaid opened this issue Jan 19, 2022 · 0 comments

Comments

@rachidelaid
Copy link

rachidelaid commented Jan 19, 2022 •
edited
Loading

we would like to congratulate you on your work, your website looks code. but we want to apply some small changes:

  • it would look better if you reset your padding and margin in start block *{} instead of targeting every element in the page.
  • we suggest giving the mobile menu a bigger z-index so it would be above all the elements.
  • we don't think you need those if statements in your index.js to toggle the mobile menu.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@rachidelaid