Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Article properties should not be optional #13

Closed
olaven opened this issue Jan 19, 2021 · 0 comments · Fixed by #21
Closed

Article properties should not be optional #13

olaven opened this issue Jan 19, 2021 · 0 comments · Fixed by #21
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@olaven
Copy link
Owner

olaven commented Jan 19, 2021

Most article properties are optional right now.
This made some development easier, but it is not wize in the long run.
I think most of the properties on Article should be compulsory.

Where that cannot be guaranteed (e.g. converter functions), Partial<Article> should be
used instead of Article.

@olaven olaven added enhancement New feature or request good first issue Good for newcomers labels Jan 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant