Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

4.2.0 ReactiveData: Uncaught (in promise) ReferenceError: origFuncs is not defined #1792

Closed
Tommy-Hoo opened this issue Feb 12, 2019 · 2 comments
Assignees
Labels
Bug Bug awaiting resolution

Comments

@Tommy-Hoo
Copy link

Describe the bug
Reactive data module throws an error on calling setData() method. If I switch the ReactiveData option to false, that error is not going to occur.

Tabulator Info

  • Which version of Tabulator are you using?
  • 4.2.0

To Reproduce
Steps to reproduce the behavior:

  1. Go to 'https://codepen.io/wonderfultommy/pen/zeWVpE'
  2. Click on 'Set Data' button
  3. See error

Expected behavior
The new data should be set properly without error message

Desktop (please complete the following information):

  • OS: Windows 10
  • Browser : Chrome 70.0.3538.110 (Official Build) (64-bit)
  • Version 4.2.0

Additional context
Maybe there was an issue in ReactiveData.prototype.unwatchData method at

value: origFuncs.push,
.
I'm confused on that the "value" is always "origFuncs.push" when it restores the methods of Array. Should we use "this.origFuncs[key]" ?

Thanks,
Tommy

@olifolkerd olifolkerd self-assigned this Feb 12, 2019
@olifolkerd olifolkerd added the Bug Bug awaiting resolution label Feb 12, 2019
@olifolkerd
Copy link
Owner

Hey @Tommy-Hoo

Thanks for getting in touch, That is definitely a bug! i will get it fixed in this weekends patch release.

Cheers

Oli :)

@olifolkerd
Copy link
Owner

I have pushed a fix for this to the master branch and will include it in a release this evening

Cheers

Oli :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Bug awaiting resolution
Projects
None yet
Development

No branches or pull requests

2 participants