Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test update to python 3.6.5 and force env in travis #209

Merged
merged 3 commits into from
May 3, 2018
Merged

Conversation

jaredbriskman
Copy link
Contributor

Resolves #207 and Fixes #165 .

Not sure if this will actually work with heroku and travis, so I'm creating a review app to take a look.

@@ -1,10 +1,17 @@
language: python

python:
- '3.6'
group: travis_latest
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This moves away from the stable lts, and to the more feature filled latest image. A little more info here.

@jaredbriskman
Copy link
Contributor Author

jaredbriskman commented May 3, 2018

It looks like even the current travis-latest image doesn't have python 3.6.5 installed, but when the minor version is requested, it will automatically install it. I'm not sure this will be cached, so it might be adding about a minute to the overall CI time.
At this point, we might not strictly need the latest travis group vs the LTS, but I think the latest should soon have python 3.6.5 installed by default.

Deploying to Heroku actually works fine, python 3.6.5 is indeed now supported by the buildpack, even though the documentation has not been updated.

@jaredbriskman jaredbriskman requested a review from osteele May 3, 2018 20:13
@osteele osteele merged commit 25a454d into dev May 3, 2018
@osteele osteele deleted the jwb/python-upgrade branch May 3, 2018 20:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants