Periodic eslint #231
Merged
Periodic eslint #231
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 307
💛 - Coveralls |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
5f24c00 Fix eslint, add test cases, for PlainEnglishRecurrence
8207216 Test, de-lint RecurrenceSelector
a85f042 Add yarn:coverage
aa75ca5 Rename reccurs -> recurs
62e1513 Remove some eslint warning exemptions
Required
Changes must conform to these requirements:
yarn testpasses. All new and existing tests pass.yarn lintpasses. All new code follows the code style of this project.Aspirational
We don't yet require these, but they are nice to have: