Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Olive Compositor doesn't actually compose anything #6

Closed
itsmattkc opened this issue Jan 29, 2018 · 2 comments
Closed

Olive Compositor doesn't actually compose anything #6

itsmattkc opened this issue Jan 29, 2018 · 2 comments
Assignees
@itsmattkc

Comments

@itsmattkc
Copy link
Contributor

All videos are blown up full screen with no transform functions for position, scale, rotation, etc.
@itsmattkc
Copy link
Contributor Author

Rudimentary compositing was added in 19941f2 but performance has worsened significantly. Compositing also does not yet take "higher" clips into priority.

@itsmattkc itsmattkc self-assigned this Feb 1, 2018
itsmattkc pushed a commit that referenced this issue Feb 2, 2018
addressed #6 and wrote full implementation handling frame rate dispar…
aa780b1 
…ities
@itsmattkc
Copy link
Contributor Author

itsmattkc commented Feb 2, 2018 •
edited

Implemented as of aa780b1. Performance was improved by switching back to YUV (RGB was used in 19941f2 and was causing the performance drops). Additionally frames are cached to handle frame rate disparities properly and "higher" clips are shown in front of "lower" clips on the timeline as expected.

@DaniSeeh DaniSeeh mentioned this issue Mar 5, 2019
Closed
@AGI-THB AGI-THB mentioned this issue Mar 16, 2019
Closed
@cgvirus cgvirus mentioned this issue Sep 19, 2020
Closed
@Corvus69 Corvus69 mentioned this issue Jan 10, 2021
Closed
@MickBuntu MickBuntu mentioned this issue Jan 20, 2021
Closed
@krischan941 krischan941 mentioned this issue Mar 23, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@itsmattkc itsmattkc

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@itsmattkc