Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Balancer Heartbeat Implementation #5

Open
Bubsavvage opened this issue Jul 10, 2019 · 1 comment
Open

Balancer Heartbeat Implementation #5

Bubsavvage opened this issue Jul 10, 2019 · 1 comment

Comments

@Bubsavvage
Copy link

Bubsavvage commented Jul 10, 2019

Currently it seems that a connection is considered broken if the url provided to the balancer throws an error or returns any status code other than 200. Ideally, I think the case for a valid endpoint would simply just be the connection as, in our case anyway, the root url we provide returns a status of 404 because nothing is provided at our root location. However, it still is considered "up" and/or can receive connections.

Example
http://ourendpoint:80 -> 404
http://ourendpoint:80/path/to/res -> 200

A valid endpoint should be justified in terms of whether or not is connecting or not i think. If we have an issue with our res then that's our problem. Maybe provide an option to remove an endpoint from the balancer if the amount of certain status codes besides 200 exceeds a specified amount? Not sure. I just wanted to open it up for discussion.

@olivere
Copy link
Owner

olivere commented Jul 10, 2019

You're probably right in that the package could be more open for configuration by default, e.g. by providing a way to pass in the status codes where connections are to be considered broken and healthy.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants