Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Questions about Project! #22

Closed
sfrique opened this issue Dec 4, 2018 · 3 comments
Closed

Questions about Project! #22

sfrique opened this issue Dec 4, 2018 · 3 comments

Comments

@sfrique
Copy link

sfrique commented Dec 4, 2018

Hello,

I was pointed to this project when I asked if flux would have alerts for deploys etc at OSS.

So i have a few questions!

Is there any reason why not to implement that direct at flux oss?

This works with helm-op ? We use flux with helm-op for everything.
If yes, does it get git url from the release.

Are there other goals? (cause of the name)

Is there an example msg on how it would appears?

Sorry I didn't look at the code yet, so I am asking this questions!

Thanks!

@oliviabarrick
Copy link
Owner

Hi!

Is there any reason why not to implement that direct at flux oss?

Mainly just simplicity of implementation (a separate service meant I didn’t have to work with the Flux team on the design), a desire to keep the Flux codebase as simple as possible, and because I didn’t know what the Flux team’s response would be to it given that slack notifications are a paid feature of weave cloud (if I remember correctly). There’s no technical reasons that it couldn’t be a part of Flux, just no current plans to do that.

This works with helm-op ? We use flux with helm-op for everything.

You can get notifications to updates to your FluxHelmReleases but not events specific to the helm operator or tiller. There’s a ticket for adding events to helm-operator: https://github.com/weaveworks/flux/issues/1335

are there other goals? (Because of the name)

The name is a play on Weave Cloud, I did leave it open ended in case I thought of more useful features to bundle in, but currently no plans 🙂

Is there an example msg on how it would appears?

There should be an example in the README, you can also customize the messages using Go templating.

@oliviabarrick
Copy link
Owner

Actually there’s not a screenshot in the README! I’ll have to add one. See one here: https://imgur.com/a/oVl9bsr

@sfrique
Copy link
Author

sfrique commented Dec 5, 2018

Thank you for all the info!

@sfrique sfrique closed this as completed Dec 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants