Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Try to fix macOS X blank screen when leaving editor fullscreen mode #482

Merged

Conversation

gedakc
Copy link
Collaborator

@gedakc gedakc commented Feb 8, 2019

Ensure showNormal() is called after leaving showFullScreen().

See issue #24.

References:

https://stackoverflow.com/questions/31666744/pyqt5-can-not-close-a-topmost-fullscreen-qdialog-on-mac-osx

https://doc.qt.io/qt-5/qwidget.html#showFullScreen

  • To return from full-screen mode, call showNormal().

https://pythonprogramminglanguage.com/destructor/

Note that these changes have been tested on Kubuntu 16.04 GNU/Linux and Windows XP with no adverse effects observed.

@gedakc gedakc merged commit 1ae0a77 into olivierkes:develop Feb 9, 2019
@gedakc gedakc deleted the i24-blank-screen-after-leaving-fullscreen branch February 9, 2019 18:01
@gedakc gedakc added this to the 0.9.0 milestone Feb 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant