Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spelling: crash and dataloss #668

Closed
wants to merge 1 commit into from

Conversation

comradekingu
Copy link
Contributor

No description provided.

gedakc added a commit to gedakc/manuskript that referenced this pull request Jan 9, 2020
Two separate pull requests indicate an issue translating the warning
for when an import is attempted with PyQt/Qt versions 5.11 and 5.12.
As such change the warning message.

See PRs olivierkes#668 and olivierkes#701.
@gedakc
Copy link
Collaborator

gedakc commented Jan 9, 2020

@comradekingu does the new wording in PR #715 address your concerns?

gedakc added a commit that referenced this pull request Jan 15, 2020
Two separate pull requests indicate an issue translating the warning
for when an import is attempted with PyQt/Qt versions 5.11 and 5.12.
As such change the warning message.

See PRs #668 and #701.
@gedakc
Copy link
Collaborator

gedakc commented Jan 15, 2020

Closing this PR. The correction in wording has been implemented with the merge of PR #715.

@gedakc gedakc closed this Jan 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants