Change wording of import warning for PyQt/Qt versions 5.11 and 5.12 #715
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Two separate pull requests indicate an issue translating the warning for when an import is attempted with PyQt/Qt versions 5.11 and 5.12. As such change the warning message. See PRs olivierkes#668 and olivierkes#701.
This was referenced Jan 9, 2020
|
@gedakc Edit: "a loss of data" is redundant. Could do without the "a". |
From our testing any combination of Qt and PyQt with versions 5.11.x and 5.12.x caused Manuskript to crash when choosing File -> Import. Normally the PyQt versions mirror the version number of Qt, but not always.
'Agreed. However I think I'll leave it in as it may already be translated in other languages and I'd prefer not to cause extra work for such a minor change. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Two separate pull requests indicate an issue translating the warning
for when an import is attempted with PyQt/Qt versions 5.11 and 5.12.
As such change the warning message.
See PRs #668 and #701.
Following is a screen shot of the warning message when run on Ubuntu 18.10.