Fixes for a number of reported bugs #901
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In addition to fixing the bug, related code that allowed this one to slip under the radar has been cleaned up. Validation of the FILENAME argument is now performed during parsing.
This takes care of the following warning in our log file: Qt WebEngine seems to be initialized from a plugin. Please set Qt::AA_ShareOpenGLContexts using QCoreApplication::setAttribute before constructing QGuiApplication
If a project only had one character, and it was marked as a POV character, then that could lead to the accessing of a non-existent second character. (Yes. That code was very broken.) Fixes issues 843, 875, 896.
QDocument::toPlainText() has the stupid decision to convert nbsp to spaces in it, which our users obviously hate. Unfortunately, this is out of our control to fix completely. It is a very deep rabbit hole. :( Typing non-breaking spaces in the editor now works. Reopening these files at a later point has these characters remain intact. What does NOT work is copy-pasting non-breaking spaces. These will end up looking like normal spaces when you paste them somewhere else, be it in Manuskript or some other document. In other words: it is impossible for users to verify whether something is a non-breaking space or an ordinary one. I realize that it makes this partial fix meaningless for many. Sorry. :/ Partially fixes issue 738.
A long time ago, I identified this failure but wasn't sure why it was failing. I still don't know why, but the emergency fix at least prevents other people from running into it. As a bonus, since we have a proper logging facility now, we can actually log it as I desired to do back then! This commit tentatively fixes issue 729.
This was
linked to
issues
Jul 10, 2021
|
So if I understand this correctly, I will keep #738 open. The other connected issues will be closed. Good job. ^^ |
Correct. |
|
@worstje thanks for your effort! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes issues #729, #843, #875, #896, #898.
It also improves issue #738 but is far from fixing it perfectly.
Please don't squash the commits together, but preserve them to leave the commit messages and associated code changes identifiable. 馃槃